divijvaidya commented on PR #14266: URL: https://github.com/apache/kafka/pull/14266#issuecomment-1689491667
> the remote log manager configs are left as internal until the required implementation is complete. Some of these configs are implemented and some aren't. We want to expose the configurations which are already implemented. As an example, `REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP` should be exposed in the documentation since it is implemented but `REMOTE_LOG_INDEX_FILE_CACHE_TOTAL_SIZE_BYTES_PROP` isn't. As part of this PR, I would suggest that you look through all properties in RemoteLogManagerConfig, see which ones are actually being used in the code, make them external (i.e. change from `defineInternal` to `define`) and keep `defineInternal` for the ones which are not being used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
