jeffkbkim commented on code in PR #14124: URL: https://github.com/apache/kafka/pull/14124#discussion_r1303413821
########## clients/src/main/resources/common/message/ConsumerGroupDescribeRequest.json: ########## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "apiKey": 71, Review Comment: should this be 69? what's the reason for 71? ########## clients/src/main/java/org/apache/kafka/common/requests/ConsumerGroupDescribeRequest.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.requests; + +import org.apache.kafka.common.message.ConsumerGroupDescribeRequestData; +import org.apache.kafka.common.message.ConsumerGroupDescribeResponseData; +import org.apache.kafka.common.protocol.ApiKeys; +import org.apache.kafka.common.protocol.ByteBufferAccessor; +import org.apache.kafka.common.protocol.Errors; + +import java.nio.ByteBuffer; + +public class ConsumerGroupDescribeRequest extends AbstractRequest { + + public static class Builder extends AbstractRequest.Builder<ConsumerGroupDescribeRequest> { + + private final ConsumerGroupDescribeRequestData data; + + public Builder(ConsumerGroupDescribeRequestData data) { + this(data, false); + } + + public Builder(ConsumerGroupDescribeRequestData data, boolean enableUnstableLastVersion) { + super(ApiKeys.CONSUMER_GROUP_DESCRIBE, enableUnstableLastVersion); + this.data = data; + } + + @Override + public ConsumerGroupDescribeRequest build(short version) { + return new ConsumerGroupDescribeRequest(data, version); + } + + @Override + public String toString() { + return data.toString(); + } + } + + private final ConsumerGroupDescribeRequestData data; + + public ConsumerGroupDescribeRequest(ConsumerGroupDescribeRequestData data, short version) { + super(ApiKeys.CONSUMER_GROUP_DESCRIBE, version); + this.data = data; + } + + @Override + public ConsumerGroupDescribeResponse getErrorResponse(int throttleTimeMs, Throwable e) { + ConsumerGroupDescribeResponseData data = new ConsumerGroupDescribeResponseData() + .setThrottleTimeMs(throttleTimeMs); + // Set error for each group based on e Review Comment: how's "Set error for each group"? ########## clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json: ########## @@ -0,0 +1,98 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "apiKey": 71, Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
