Taher-Ghaleb commented on PR #14264: URL: https://github.com/apache/kafka/pull/14264#issuecomment-1692591866
Thanks @jolshan for your response. `assertThrows` makes the verification of exceptions clearer and more intuitive, thus improving code readability compared to the annotation approach. [It is considered a test smell in the research literature](https://ieeexplore.ieee.org/abstract/document/9769994/). One possible research is due to developers not keeping up to date with recent versions of testing frameworks. Therefore, we aim in our research to get an idea of whether such a refactoring is acceptable in practice, and whether developers prefer to keep using `@Test(expected)` in certain testing scenarios. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org