[ https://issues.apache.org/jira/browse/KAFKA-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496248#comment-16496248 ]
ASF GitHub Bot commented on KAFKA-6973: --------------------------------------- huxihx opened a new pull request #5106: KAFKA-6973: TopicCommand should verify topic-level config URL: https://github.com/apache/kafka/pull/5106 KAFKA-6973: https://issues.apache.org/jira/browse/KAFKA-6973 Specifying an invalid config other than `CreateTime` or `LogAppendTime` will cause broker restarting to fail. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > setting invalid timestamp causes Kafka broker restart to fail > ------------------------------------------------------------- > > Key: KAFKA-6973 > URL: https://issues.apache.org/jira/browse/KAFKA-6973 > Project: Kafka > Issue Type: Bug > Components: admin > Affects Versions: 1.1.0 > Reporter: Paul Brebner > Assignee: huxihx > Priority: Critical > > Setting timestamp to invalid value causes Kafka broker to fail upon startup. > E.g. > ./kafka-topics.sh --create --zookeeper localhost --topic duck3 --partitions 1 > --replication-factor 1 --config message.timestamp.type=boom > > Also note that the docs says the parameter name is > log.message.timestamp.type, but this is silently ignored. > This works with no error for the invalid timestamp value. But next time you > restart Kafka: > > [2018-05-29 13:09:05,806] FATAL [KafkaServer id=0] Fatal error during > KafkaServer startup. Prepare to shutdown (kafka.server.KafkaServer) > java.util.NoSuchElementException: Invalid timestamp type boom > at org.apache.kafka.common.record.TimestampType.forName(TimestampType.java:39) > at kafka.log.LogConfig.<init>(LogConfig.scala:94) > at kafka.log.LogConfig$.fromProps(LogConfig.scala:279) > at kafka.log.LogManager$$anonfun$17.apply(LogManager.scala:786) > at kafka.log.LogManager$$anonfun$17.apply(LogManager.scala:785) > at > scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234) > at > scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:234) > at scala.collection.immutable.HashMap$HashMap1.foreach(HashMap.scala:221) > at scala.collection.immutable.HashMap$HashTrieMap.foreach(HashMap.scala:428) > at scala.collection.immutable.HashMap$HashTrieMap.foreach(HashMap.scala:428) > at scala.collection.TraversableLike$class.map(TraversableLike.scala:234) > at scala.collection.AbstractTraversable.map(Traversable.scala:104) > at kafka.log.LogManager$.apply(LogManager.scala:785) > at kafka.server.KafkaServer.startup(KafkaServer.scala:222) > at kafka.server.KafkaServerStartable.startup(KafkaServerStartable.scala:38) > at kafka.Kafka$.main(Kafka.scala:92) > at kafka.Kafka.main(Kafka.scala) > [2018-05-29 13:09:05,811] INFO [KafkaServer id=0] shutting down > -- This message was sent by Atlassian JIRA (v7.6.3#76005)