[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
----------------------------------
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put those in https://issues.apache.org/jira/browse/KAFKA-14132. Tests here rely
solely on EasyMock.{color}
Unless stated in brackets the tests are in the streams module.
A list of tests which still require to be moved from EasyMock to Mockito as of
2nd of August 2022 which do not have a Jira issue and do not have pull requests
I am aware of which are opened:
{color:#ff8b00}In Review{color}
{color:#00875a}Merged{color}
# {color:#00875a}WorkerConnectorTest{color} (connect) (owner: [~yash.mayya] )
# {color:#00875a}WorkerCoordinatorTest{color} (connect) (owner: [~yash.mayya] )
# {color:#00875a}RootResourceTest{color} (connect) (owner: [~yash.mayya] )
# {color:#00875a}ByteArrayProducerRecordEquals{color} (connect) (owner:
[~yash.mayya] )
# {color:#00875a}KStreamFlatTransformTest{color} (owner: Christo)
# {color:#00875a}KStreamFlatTransformValuesTest{color} (owner: Christo)
# {color:#00875a}KStreamPrintTest{color} (owner: Christo)
# {color:#00875a}KStreamRepartitionTest{color} (owner: Christo)
# {color:#00875a}MaterializedInternalTest{color} (owner: Christo)
# {color:#00875a}TransformerSupplierAdapterTest{color} (owner: Christo)
# {color:#00875a}KTableSuppressProcessorMetricsTest{color} (owner: Christo)
# {color:#00875a}ClientUtilsTest{color} (owner: Christo)
# {color:#00875a}HighAvailabilityStreamsPartitionAssignorTest{color} (owner:
Christo)
# {color:#00875a}TopologyTest{color} (owner: Christo)
# {color:#00875a}KTableSuppressProcessorTest{color} (owner: Christo)
# {color:#00875a}ChangeLoggingSessionBytesStoreTest{color} (owner: Christo)
# {color:#00875a}ChangeLoggingTimestampedWindowBytesStoreTest{color} (owner:
Christo)
# {color:#00875a}ChangeLoggingWindowBytesStoreTest{color} (owner: Christo)
# {color:#00875a}MeteredTimestampedWindowStoreTest{color} (owner: Christo)
# {color:#00875a}StreamsRebalanceListenerTest{color} (owner: Christo)
# {color:#00875a}TimestampedKeyValueStoreMaterializerTest{color} (owner:
Christo)
# {color:#00875a}CachingInMemoryKeyValueStoreTest{color} (owner: Christo)
# {color:#00875a}CachingInMemorySessionStoreTest{color} (owner: Christo)
# {color:#00875a}CachingPersistentSessionStoreTest{color} (owner: Christo)
# {color:#00875a}CachingPersistentWindowStoreTest{color} (owner: Christo)
# {color:#00875a}ChangeLoggingKeyValueBytesStoreTest{color} (owner: Christo)
# {color:#00875a}ChangeLoggingTimestampedKeyValueBytesStoreTest{color} (owner:
Christo)
# {color:#00875a}CompositeReadOnlyWindowStoreTest{color} (owner: Christo)
# {color:#00875a}KeyValueStoreBuilderTest{color} (owner: Christo)
# {color:#00875a}RocksDBStoreTest{color} (owner: Christo)
# {color:#00875a}StreamThreadStateStoreProviderTest{color} (owner: Christo)
# {color:#ff8b00}TaskManagerTest{color} (owner: Christo)
# {color:#00875a}InternalTopicManagerTest{color} (owner: Christo)
# {color:#00875a}ProcessorContextImplTest{color} (owner: Christo)
# {color:#00875a}WriteConsistencyVectorTest{color} (owner: Christo)
# {color:#00875a}StreamsAssignmentScaleTest{color} (owner: Christo)
# {color:#00875a}StreamsPartitionAssignorTest{color} (owner: Christo)
# {color:#00875a}AssignmentTestUtils{color} (owner: Christo)
# {color:#ff8b00}ProcessorStateManagerTest{color} (owner: Matthew) (takeover:
Christo)
# {color:#ff8b00}StandbyTaskTest{color} (owner: Matthew)
# {color:#ff8b00}StoreChangelogReaderTest{color} (owner: Matthew)
# {color:#ff8b00}StreamTaskTest{color} (owner: Matthew)
# {color:#ff8b00}StreamThreadTest{color} (owner: Matthew) (takeover: Christo)
# {color:#ff8b00}StreamsMetricsImplTest{color} (owner: Dalibor) (Captured in
https://issues.apache.org/jira/browse/KAFKA-12947)
# {color:#00875a}TimeOrderedCachingPersistentWindowStoreTest{color} (owner:
[~shekharrajak])
# {color:#00875a}TimeOrderedWindowStoreTest{color} (owner: [~shekharrajak])
[https://github.com/apache/kafka/pull/12777]
# {color:#ff8b00}AbstractStreamTest{color} (owner: Christo)
# {color:#00875a}KStreamTransformValuesTest{color} (owner: Christo)
# {color:#00875a}KTableImplTest{color} (owner: Christo)
# {color:#00875a}KTableTransformValuesTest{color} (owner: Christo)
# {color:#00875a}SessionCacheFlushListenerTest{color} (owner: Christo)
# {color:#00875a}TimestampedCacheFlushListenerTest{color} (owner: Christo)
# {color:#00875a}TimestampedTupleForwarderTest{color} (owner: Christo)
# {color:#00875a}ActiveTaskCreatorTest{color} (owner: Christo)
# {color:#00875a}ChangelogTopicsTest{color} (owner: Christo)
# {color:#00875a}GlobalProcessorContextImplTest{color} (owner: Christo)
# {color:#00875a}RecordCollectorTest{color} (owner: Christo)
# {color:#00875a}StateRestoreCallbackAdapterTest{color} (owner: Christo)
# {color:#00875a}StoreToProcessorContextAdapterTest{color} (owner: Christo)
# StreamsProducerTest (owner: Nelson)
# TopologyMetadataTest (owner: Nelson)
# GlobalStateStoreProviderTest (owner: Nelson)
# KeyValueIteratorFacadeTest (owner: [~yash.mayya])
# KeyValueSegmentTest (owner: [~yash.mayya])
# MeteredKeyValueStoreTest (owner: [~yash.mayya])
# MeteredSessionStoreTest (owner: [~yash.mayya])
# MeteredTimestampedKeyValueStoreTest (owner: [~yash.mayya])
# MeteredWindowStoreTest (owner: [~yash.mayya])
# ReadOnlyKeyValueStoreFacadeTest (owner: [~yash.mayya])
# ReadOnlyWindowStoreFacadeTest (owner: [~yash.mayya])
# RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest (owner: Fei
Xie)
# {color:#00875a}RocksDBRangeIteratorTest{color} (owner: Christo)
# {color:#00875a}TimestampedKeyValueStoreBuilderTest{color} (owner: Christo)
# {color:#00875a}TimestampedSegmentTest{color} (owner: Christo)
# TimestampedWindowStoreBuilderTest
# {color:#ff8b00}WindowStoreBuilderTest{color} (owner: [~yash.mayya] -
[https://github.com/apache/kafka/pull/14152])
# {color:#ff8b00}RocksDBMetricsRecordingTriggerTest{color} (owner: Christo)
# {color:#00875a}SessionStoreBuilderTest{color} (owner: Nelson)
*The coverage report for the above tests after the change should be >= to what
the coverage is now.*
was:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put those in https://issues.apache.org/jira/browse/KAFKA-14132. Tests here rely
solely on EasyMock.{color}
Unless stated in brackets the tests are in the streams module.
A list of tests which still require to be moved from EasyMock to Mockito as of
2nd of August 2022 which do not have a Jira issue and do not have pull requests
I am aware of which are opened:
{color:#ff8b00}In Review{color}
{color:#00875a}Merged{color}
# {color:#00875a}WorkerConnectorTest{color} (connect) (owner: [~yash.mayya] )
# {color:#00875a}WorkerCoordinatorTest{color} (connect) (owner: [~yash.mayya] )
# {color:#00875a}RootResourceTest{color} (connect) (owner: [~yash.mayya] )
# {color:#00875a}ByteArrayProducerRecordEquals{color} (connect) (owner:
[~yash.mayya] )
# {color:#00875a}KStreamFlatTransformTest{color} (owner: Christo)
# {color:#00875a}KStreamFlatTransformValuesTest{color} (owner: Christo)
# {color:#00875a}KStreamPrintTest{color} (owner: Christo)
# {color:#00875a}KStreamRepartitionTest{color} (owner: Christo)
# {color:#00875a}MaterializedInternalTest{color} (owner: Christo)
# {color:#00875a}TransformerSupplierAdapterTest{color} (owner: Christo)
# {color:#00875a}KTableSuppressProcessorMetricsTest{color} (owner: Christo)
# {color:#00875a}ClientUtilsTest{color} (owner: Christo)
# {color:#00875a}HighAvailabilityStreamsPartitionAssignorTest{color} (owner:
Christo)
# {color:#00875a}TopologyTest{color} (owner: Christo)
# {color:#00875a}KTableSuppressProcessorTest{color} (owner: Christo)
# {color:#00875a}ChangeLoggingSessionBytesStoreTest{color} (owner: Christo)
# {color:#00875a}ChangeLoggingTimestampedWindowBytesStoreTest{color} (owner:
Christo)
# {color:#00875a}ChangeLoggingWindowBytesStoreTest{color} (owner: Christo)
# {color:#00875a}MeteredTimestampedWindowStoreTest{color} (owner: Christo)
# {color:#00875a}StreamsRebalanceListenerTest{color} (owner: Christo)
# {color:#00875a}TimestampedKeyValueStoreMaterializerTest{color} (owner:
Christo)
# {color:#00875a}CachingInMemoryKeyValueStoreTest{color} (owner: Christo)
# {color:#00875a}CachingInMemorySessionStoreTest{color} (owner: Christo)
# {color:#00875a}CachingPersistentSessionStoreTest{color} (owner: Christo)
# {color:#00875a}CachingPersistentWindowStoreTest{color} (owner: Christo)
# {color:#00875a}ChangeLoggingKeyValueBytesStoreTest{color} (owner: Christo)
# {color:#00875a}ChangeLoggingTimestampedKeyValueBytesStoreTest{color} (owner:
Christo)
# {color:#00875a}CompositeReadOnlyWindowStoreTest{color} (owner: Christo)
# {color:#00875a}KeyValueStoreBuilderTest{color} (owner: Christo)
# {color:#00875a}RocksDBStoreTest{color} (owner: Christo)
# {color:#00875a}StreamThreadStateStoreProviderTest{color} (owner: Christo)
# {color:#ff8b00}TaskManagerTest{color} (owner: Christo)
# {color:#00875a}InternalTopicManagerTest{color} (owner: Christo)
# {color:#00875a}ProcessorContextImplTest{color} (owner: Christo)
# {color:#00875a}WriteConsistencyVectorTest{color} (owner: Christo)
# {color:#00875a}StreamsAssignmentScaleTest{color} (owner: Christo)
# {color:#00875a}StreamsPartitionAssignorTest{color} (owner: Christo)
# {color:#00875a}AssignmentTestUtils{color} (owner: Christo)
# {color:#ff8b00}ProcessorStateManagerTest{color} (owner: Matthew) (takeover:
Christo)
# {color:#ff8b00}StandbyTaskTest{color} (owner: Matthew)
# {color:#ff8b00}StoreChangelogReaderTest{color} (owner: Matthew)
# {color:#ff8b00}StreamTaskTest{color} (owner: Matthew)
# {color:#ff8b00}StreamThreadTest{color} (owner: Matthew) (takeover: Christo)
# {color:#ff8b00}StreamsMetricsImplTest{color} (owner: Dalibor) (Captured in
https://issues.apache.org/jira/browse/KAFKA-12947)
# {color:#00875a}TimeOrderedCachingPersistentWindowStoreTest{color} (owner:
[~shekharrajak])
# {color:#00875a}TimeOrderedWindowStoreTest{color} (owner: [~shekharrajak])
[https://github.com/apache/kafka/pull/12777]
# {color:#ff8b00}AbstractStreamTest{color} (owner: Christo)
# {color:#ff8b00}KStreamTransformValuesTest{color} (owner: Christo)
# {color:#ff8b00}KTableImplTest{color} (owner: Christo)
# {color:#ff8b00}KTableTransformValuesTest{color} (owner: Christo)
# {color:#00875a}SessionCacheFlushListenerTest{color} (owner: Christo)
# {color:#00875a}TimestampedCacheFlushListenerTest{color} (owner: Christo)
# {color:#00875a}TimestampedTupleForwarderTest{color} (owner: Christo)
# {color:#00875a}ActiveTaskCreatorTest{color} (owner: Christo)
# {color:#00875a}ChangelogTopicsTest{color} (owner: Christo)
# {color:#00875a}GlobalProcessorContextImplTest{color} (owner: Christo)
# {color:#00875a}RecordCollectorTest{color} (owner: Christo)
# {color:#00875a}StateRestoreCallbackAdapterTest{color} (owner: Christo)
# {color:#00875a}StoreToProcessorContextAdapterTest{color} (owner: Christo)
# StreamsProducerTest (owner: Nelson)
# TopologyMetadataTest (owner: Nelson)
# GlobalStateStoreProviderTest (owner: Nelson)
# KeyValueIteratorFacadeTest (owner: [~yash.mayya])
# KeyValueSegmentTest (owner: [~yash.mayya])
# MeteredKeyValueStoreTest (owner: [~yash.mayya])
# MeteredSessionStoreTest (owner: [~yash.mayya])
# MeteredTimestampedKeyValueStoreTest (owner: [~yash.mayya])
# MeteredWindowStoreTest (owner: [~yash.mayya])
# ReadOnlyKeyValueStoreFacadeTest (owner: [~yash.mayya])
# ReadOnlyWindowStoreFacadeTest (owner: [~yash.mayya])
# RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest (owner: Fei
Xie)
# {color:#00875a}RocksDBRangeIteratorTest{color} (owner: Christo)
# {color:#00875a}TimestampedKeyValueStoreBuilderTest{color} (owner: Christo)
# {color:#00875a}TimestampedSegmentTest{color} (owner: Christo)
# TimestampedWindowStoreBuilderTest
# {color:#ff8b00}WindowStoreBuilderTest{color} (owner: [~yash.mayya] -
[https://github.com/apache/kafka/pull/14152])
# {color:#ff8b00}RocksDBMetricsRecordingTriggerTest{color} (owner: Christo)
# {color:#00875a}SessionStoreBuilderTest{color} (owner: Nelson)
*The coverage report for the above tests after the change should be >= to what
the coverage is now.*
> Remaining EasyMock to Mockito tests
> -----------------------------------
>
> Key: KAFKA-14133
> URL: https://issues.apache.org/jira/browse/KAFKA-14133
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Christo Lolov
> Assignee: Christo Lolov
> Priority: Major
>
> {color:#de350b}There are tests which use both PowerMock and EasyMock. I have
> put those in https://issues.apache.org/jira/browse/KAFKA-14132. Tests here
> rely solely on EasyMock.{color}
> Unless stated in brackets the tests are in the streams module.
> A list of tests which still require to be moved from EasyMock to Mockito as
> of 2nd of August 2022 which do not have a Jira issue and do not have pull
> requests I am aware of which are opened:
> {color:#ff8b00}In Review{color}
> {color:#00875a}Merged{color}
> # {color:#00875a}WorkerConnectorTest{color} (connect) (owner: [~yash.mayya] )
> # {color:#00875a}WorkerCoordinatorTest{color} (connect) (owner:
> [~yash.mayya] )
> # {color:#00875a}RootResourceTest{color} (connect) (owner: [~yash.mayya] )
> # {color:#00875a}ByteArrayProducerRecordEquals{color} (connect) (owner:
> [~yash.mayya] )
> # {color:#00875a}KStreamFlatTransformTest{color} (owner: Christo)
> # {color:#00875a}KStreamFlatTransformValuesTest{color} (owner: Christo)
> # {color:#00875a}KStreamPrintTest{color} (owner: Christo)
> # {color:#00875a}KStreamRepartitionTest{color} (owner: Christo)
> # {color:#00875a}MaterializedInternalTest{color} (owner: Christo)
> # {color:#00875a}TransformerSupplierAdapterTest{color} (owner: Christo)
> # {color:#00875a}KTableSuppressProcessorMetricsTest{color} (owner: Christo)
> # {color:#00875a}ClientUtilsTest{color} (owner: Christo)
> # {color:#00875a}HighAvailabilityStreamsPartitionAssignorTest{color} (owner:
> Christo)
> # {color:#00875a}TopologyTest{color} (owner: Christo)
> # {color:#00875a}KTableSuppressProcessorTest{color} (owner: Christo)
> # {color:#00875a}ChangeLoggingSessionBytesStoreTest{color} (owner: Christo)
> # {color:#00875a}ChangeLoggingTimestampedWindowBytesStoreTest{color} (owner:
> Christo)
> # {color:#00875a}ChangeLoggingWindowBytesStoreTest{color} (owner: Christo)
> # {color:#00875a}MeteredTimestampedWindowStoreTest{color} (owner: Christo)
> # {color:#00875a}StreamsRebalanceListenerTest{color} (owner: Christo)
> # {color:#00875a}TimestampedKeyValueStoreMaterializerTest{color} (owner:
> Christo)
> # {color:#00875a}CachingInMemoryKeyValueStoreTest{color} (owner: Christo)
> # {color:#00875a}CachingInMemorySessionStoreTest{color} (owner: Christo)
> # {color:#00875a}CachingPersistentSessionStoreTest{color} (owner: Christo)
> # {color:#00875a}CachingPersistentWindowStoreTest{color} (owner: Christo)
> # {color:#00875a}ChangeLoggingKeyValueBytesStoreTest{color} (owner: Christo)
> # {color:#00875a}ChangeLoggingTimestampedKeyValueBytesStoreTest{color}
> (owner: Christo)
> # {color:#00875a}CompositeReadOnlyWindowStoreTest{color} (owner: Christo)
> # {color:#00875a}KeyValueStoreBuilderTest{color} (owner: Christo)
> # {color:#00875a}RocksDBStoreTest{color} (owner: Christo)
> # {color:#00875a}StreamThreadStateStoreProviderTest{color} (owner: Christo)
> # {color:#ff8b00}TaskManagerTest{color} (owner: Christo)
> # {color:#00875a}InternalTopicManagerTest{color} (owner: Christo)
> # {color:#00875a}ProcessorContextImplTest{color} (owner: Christo)
> # {color:#00875a}WriteConsistencyVectorTest{color} (owner: Christo)
> # {color:#00875a}StreamsAssignmentScaleTest{color} (owner: Christo)
> # {color:#00875a}StreamsPartitionAssignorTest{color} (owner: Christo)
> # {color:#00875a}AssignmentTestUtils{color} (owner: Christo)
> # {color:#ff8b00}ProcessorStateManagerTest{color} (owner: Matthew)
> (takeover: Christo)
> # {color:#ff8b00}StandbyTaskTest{color} (owner: Matthew)
> # {color:#ff8b00}StoreChangelogReaderTest{color} (owner: Matthew)
> # {color:#ff8b00}StreamTaskTest{color} (owner: Matthew)
> # {color:#ff8b00}StreamThreadTest{color} (owner: Matthew) (takeover: Christo)
> # {color:#ff8b00}StreamsMetricsImplTest{color} (owner: Dalibor) (Captured in
> https://issues.apache.org/jira/browse/KAFKA-12947)
> # {color:#00875a}TimeOrderedCachingPersistentWindowStoreTest{color} (owner:
> [~shekharrajak])
> # {color:#00875a}TimeOrderedWindowStoreTest{color} (owner: [~shekharrajak])
> [https://github.com/apache/kafka/pull/12777]
> # {color:#ff8b00}AbstractStreamTest{color} (owner: Christo)
> # {color:#00875a}KStreamTransformValuesTest{color} (owner: Christo)
> # {color:#00875a}KTableImplTest{color} (owner: Christo)
> # {color:#00875a}KTableTransformValuesTest{color} (owner: Christo)
> # {color:#00875a}SessionCacheFlushListenerTest{color} (owner: Christo)
> # {color:#00875a}TimestampedCacheFlushListenerTest{color} (owner: Christo)
> # {color:#00875a}TimestampedTupleForwarderTest{color} (owner: Christo)
> # {color:#00875a}ActiveTaskCreatorTest{color} (owner: Christo)
> # {color:#00875a}ChangelogTopicsTest{color} (owner: Christo)
> # {color:#00875a}GlobalProcessorContextImplTest{color} (owner: Christo)
> # {color:#00875a}RecordCollectorTest{color} (owner: Christo)
> # {color:#00875a}StateRestoreCallbackAdapterTest{color} (owner: Christo)
> # {color:#00875a}StoreToProcessorContextAdapterTest{color} (owner: Christo)
> # StreamsProducerTest (owner: Nelson)
> # TopologyMetadataTest (owner: Nelson)
> # GlobalStateStoreProviderTest (owner: Nelson)
> # KeyValueIteratorFacadeTest (owner: [~yash.mayya])
> # KeyValueSegmentTest (owner: [~yash.mayya])
> # MeteredKeyValueStoreTest (owner: [~yash.mayya])
> # MeteredSessionStoreTest (owner: [~yash.mayya])
> # MeteredTimestampedKeyValueStoreTest (owner: [~yash.mayya])
> # MeteredWindowStoreTest (owner: [~yash.mayya])
> # ReadOnlyKeyValueStoreFacadeTest (owner: [~yash.mayya])
> # ReadOnlyWindowStoreFacadeTest (owner: [~yash.mayya])
> # RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest (owner: Fei
> Xie)
> # {color:#00875a}RocksDBRangeIteratorTest{color} (owner: Christo)
> # {color:#00875a}TimestampedKeyValueStoreBuilderTest{color} (owner: Christo)
> # {color:#00875a}TimestampedSegmentTest{color} (owner: Christo)
> # TimestampedWindowStoreBuilderTest
> # {color:#ff8b00}WindowStoreBuilderTest{color} (owner: [~yash.mayya] -
> [https://github.com/apache/kafka/pull/14152])
> # {color:#ff8b00}RocksDBMetricsRecordingTriggerTest{color} (owner: Christo)
> # {color:#00875a}SessionStoreBuilderTest{color} (owner: Nelson)
> *The coverage report for the above tests after the change should be >= to
> what the coverage is now.*
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
