kamalcph commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1312693348
########## storage/src/test/java/org/apache/kafka/tiered/storage/actions/ExpectEmptyRemoteStorageAction.java: ########## @@ -36,8 +36,8 @@ public ExpectEmptyRemoteStorageAction(TopicPartition topicPartition) { public void doExecute(TieredStorageTestContext context) throws InterruptedException { TestUtils.waitForCondition(() -> { LocalTieredStorageSnapshot snapshot = context.takeTieredStorageSnapshot(); - return !snapshot.getTopicPartitions().contains(topicPartition) && - snapshot.getFilesets(topicPartition).isEmpty(); + // With KAFKA-15166, snapshot should not contain the topicPartition Review Comment: We don't differentiate the case between segment deletion and topic deletion so the underlying remote-storage-manager doesn't know when to remove any topic-level marker files/folders. In case of LocalTieredStorage, there will be empty partition directories. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org