[GitHub] [kafka] jolshan commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

[via GitHub]

jolshan commented on code in PR #14321:
URL: https://github.com/apache/kafka/pull/14321#discussion_r1313590994


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##########
@@ -823,9 +823,17 @@ public void validateOffsetCommit(
 
     /**
      * Validates the OffsetFetch request.
+     *
+     * @param memberId              The member id. This is not provided for 
generic groups.
+     * @param memberEpoch           The member epoch for consumer groups. This 
is not provided for generic groups.
+     * @param lastCommittedOffset   The last committed offsets in the timeline.
      */
     @Override
-    public void validateOffsetFetch() throws GroupIdNotFoundException {
+    public void validateOffsetFetch(
+        String memberId,

Review Comment:
   For my understanding, we pass these to be consistent with the interface, but 
we don't need it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org