elkkhan commented on code in PR #14077:
URL: https://github.com/apache/kafka/pull/14077#discussion_r1314605208
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceMetrics.java:
##########
@@ -104,12 +108,25 @@ class MirrorSourceMetrics implements AutoCloseable {
replicationLatencyAvg = new MetricNameTemplate(
"replication-latency-ms-avg", SOURCE_CONNECTOR_GROUP,
"Average time it takes records to replicate from source to
target cluster.", partitionTags);
+ replicationOffsetLag = new MetricNameTemplate(
Review Comment:
@hudeqi I hear you now - we do have a disagreement about the lag definition
and it was an oversight on my end. I will copy your reply over to the mailing
thread and will answer there to keep the discussion in one place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
