[
https://issues.apache.org/jira/browse/KAFKA-6760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498714#comment-16498714
]
ASF GitHub Bot commented on KAFKA-6760:
---------------------------------------
ijuma closed pull request #4834: KAFKA-6760: Responses not logged properly in
controller
URL: https://github.com/apache/kafka/pull/4834
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrResponse.java
b/clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrResponse.java
index c21f9a783b3..8e6324589df 100644
---
a/clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrResponse.java
+++
b/clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrResponse.java
@@ -119,4 +119,13 @@ protected Struct toStruct(short version) {
return struct;
}
+
+ @Override
+ public String toString() {
+ return "LeaderAndIsrResponse(" +
+ "responses=" + responses +
+ ", error=" + error +
+ ")";
+ }
+
}
diff --git
a/clients/src/main/java/org/apache/kafka/common/requests/StopReplicaResponse.java
b/clients/src/main/java/org/apache/kafka/common/requests/StopReplicaResponse.java
index 777416d1758..4e8efe9547a 100644
---
a/clients/src/main/java/org/apache/kafka/common/requests/StopReplicaResponse.java
+++
b/clients/src/main/java/org/apache/kafka/common/requests/StopReplicaResponse.java
@@ -115,4 +115,13 @@ protected Struct toStruct(short version) {
struct.set(ERROR_CODE, error.code());
return struct;
}
+
+ @Override
+ public String toString() {
+ return "StopReplicaResponse(" +
+ "responses=" + responses +
+ ", error=" + error +
+ ")";
+ }
+
}
diff --git
a/clients/src/test/java/org/apache/kafka/common/requests/LeaderAndIsrResponseTest.java
b/clients/src/test/java/org/apache/kafka/common/requests/LeaderAndIsrResponseTest.java
index 3eda7782743..c242555a4b0 100644
---
a/clients/src/test/java/org/apache/kafka/common/requests/LeaderAndIsrResponseTest.java
+++
b/clients/src/test/java/org/apache/kafka/common/requests/LeaderAndIsrResponseTest.java
@@ -27,6 +27,7 @@
import java.util.Map;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
public class LeaderAndIsrResponseTest {
@@ -64,4 +65,16 @@ public void testErrorCountsNoTopLevelError() {
assertEquals(1,
errorCounts.get(Errors.CLUSTER_AUTHORIZATION_FAILED).intValue());
}
+ @Test
+ public void testToString() {
+ Map<TopicPartition, Errors> errors = new HashMap<>();
+ errors.put(new TopicPartition("foo", 0), Errors.NONE);
+ errors.put(new TopicPartition("foo", 1),
Errors.CLUSTER_AUTHORIZATION_FAILED);
+ LeaderAndIsrResponse response = new LeaderAndIsrResponse(Errors.NONE,
errors);
+ String responseStr = response.toString();
+
assertTrue(responseStr.contains(LeaderAndIsrResponse.class.getSimpleName()));
+ assertTrue(responseStr.contains(errors.toString()));
+ assertTrue(responseStr.contains(Errors.NONE.name()));
+ }
+
}
diff --git
a/clients/src/test/java/org/apache/kafka/common/requests/StopReplicaResponseTest.java
b/clients/src/test/java/org/apache/kafka/common/requests/StopReplicaResponseTest.java
index 95cb3aa39e2..3a87fc64691 100644
---
a/clients/src/test/java/org/apache/kafka/common/requests/StopReplicaResponseTest.java
+++
b/clients/src/test/java/org/apache/kafka/common/requests/StopReplicaResponseTest.java
@@ -26,6 +26,7 @@
import java.util.Map;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
public class StopReplicaResponseTest {
@@ -58,4 +59,16 @@ public void testErrorCountsNoTopLevelError() {
assertEquals(1,
errorCounts.get(Errors.CLUSTER_AUTHORIZATION_FAILED).intValue());
}
+ @Test
+ public void testToString() {
+ Map<TopicPartition, Errors> errors = new HashMap<>();
+ errors.put(new TopicPartition("foo", 0), Errors.NONE);
+ errors.put(new TopicPartition("foo", 1),
Errors.CLUSTER_AUTHORIZATION_FAILED);
+ StopReplicaResponse response = new StopReplicaResponse(Errors.NONE,
errors);
+ String responseStr = response.toString();
+
assertTrue(responseStr.contains(StopReplicaResponse.class.getSimpleName()));
+ assertTrue(responseStr.contains(errors.toString()));
+ assertTrue(responseStr.contains(Errors.NONE.name()));
+ }
+
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> responses not logged properly in controller
> -------------------------------------------
>
> Key: KAFKA-6760
> URL: https://issues.apache.org/jira/browse/KAFKA-6760
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.1.0
> Reporter: Jun Rao
> Assignee: Mickael Maison
> Priority: Major
> Labels: newbie
>
> Saw the following logging in controller.log. We need to log the
> StopReplicaResponse properly in KafkaController.
> [2018-04-05 14:38:41,878] DEBUG [Controller id=0] Delete topic callback
> invoked for org.apache.kafka.common.requests.StopReplicaResponse@263d40c
> (kafka.controller.K
> afkaController)
> It seems that the same issue exists for LeaderAndIsrResponse as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
