cadonna commented on code in PR #14317:
URL: https://github.com/apache/kafka/pull/14317#discussion_r1315798587
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorder.java:
##########
@@ -373,14 +373,14 @@ private Gauge<BigInteger>
gaugeToComputeBlockCacheMetrics(final String propertyN
// values of RocksDB properties are of type unsigned
long in C++, i.e., in Java we need to use
// BigInteger and construct the object from the byte
representation of the value
result = new BigInteger(1, longToBytes(
-
valueProvider.db.getAggregatedLongProperty(ROCKSDB_PROPERTIES_PREFIX +
propertyName)
+
valueProvider.db.getLongProperty(ROCKSDB_PROPERTIES_PREFIX + propertyName)
));
break;
} else {
// values of RocksDB properties are of type unsigned
long in C++, i.e., in Java we need to use
// BigInteger and construct the object from the byte
representation of the value
result = result.add(new BigInteger(1, longToBytes(
-
valueProvider.db.getAggregatedLongProperty(ROCKSDB_PROPERTIES_PREFIX +
propertyName)
+
valueProvider.db.getLongProperty(ROCKSDB_PROPERTIES_PREFIX + propertyName)
Review Comment:
I got confirmation, the column families share the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
