kamalcph commented on code in PR #14329:
URL: https://github.com/apache/kafka/pull/14329#discussion_r1315883355
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -3487,8 +3487,12 @@ class ReplicaManagerTest {
assertTrue(replicaManager.logManager.getLog(tp0).isDefined)
}
if (enableRemoteStorage) {
- verify(mockRemoteLogManager, times(1))
- .stopPartitions(ArgumentMatchers.eq(Collections.singleton(tp0)),
ArgumentMatchers.eq(false), any())
+ if (throwIOException) {
+ verify(mockRemoteLogManager, times(0)).stopPartitions(any(), any())
Review Comment:
yes, there was a bug. Previously, we were calling the RLM#stopPartitions
twice one with `delete` set as true and false. The error partition was
by-passing through the second call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
