[GitHub] [kafka] jolshan commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

[via GitHub]

jolshan commented on code in PR #14321:
URL: https://github.com/apache/kafka/pull/14321#discussion_r1316207292


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##########
@@ -1491,10 +1526,15 @@ public void 
testConsumerGroupOffsetFetchWithUnknownMemberId() {
                 .setPartitionIndexes(Collections.singletonList(0))
         );
 
+        // Fetch offsets cases.
+        assertThrows(UnknownMemberIdException.class,
+            () -> context.fetchOffsets("group", "", 0, topics, 
Long.MAX_VALUE));

Review Comment:
   Is this testing that the empty member string will fail (ie if no member, it 
must be null?) I'm trying to understand how this test is different than the one 
below.
   
   I also noticed that the test changed the default values from empty string to 
null. Was that an error before?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org