hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1319695234
##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -159,9 +159,16 @@ class RemoteIndexCacheTest {
@Test
def testCacheEntryExpiry(): Unit = {
// close existing cache created in test setup before creating a new one
+ val cacheForEstimate = new RemoteIndexCache(2L, rsm, tpDir.toString)
+ val tpIdForEstimate = new TopicIdPartition(Uuid.randomUuid(), new
TopicPartition("foo", 0))
+ val metadataListForEstimate = generateRemoteLogSegmentMetadata(size = 1,
tpIdForEstimate)
+ val entryForEstimate =
cacheForEstimate.getIndexEntry(metadataListForEstimate.head)
+ val estimateEntryBytesSize = entryForEstimate.entrySizeBytes()
+ Utils.closeQuietly(cacheForEstimate, "RemoteIndexCache created for
estimating entry size")
Review Comment:
"@BeforeAll" in scala may be a bit more complicated to implement here. So I
extracted this logic into a separate method. @showuon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
