[GitHub] [kafka] divijvaidya commented on a diff in pull request #14344: Resolve checkstyle cache miss

[via GitHub]

divijvaidya commented on code in PR #14344:
URL: https://github.com/apache/kafka/pull/14344#discussion_r1321351825


##########
build.gradle:
##########
@@ -685,6 +685,7 @@ subprojects {
   }
 
   checkstyle {
+    configDirectory = rootProject.layout.projectDirectory.dir("checkstyle")

Review Comment:
   is this rootDir.dir("checkstyle")? or `"File(rootDir, "checkstyle")"`?
   
   My point is, could we make it relative to rootDir here?



##########
build.gradle:
##########
@@ -685,6 +685,7 @@ subprojects {
   }
 
   checkstyle {
+    configDirectory = rootProject.layout.projectDirectory.dir("checkstyle")
     configFile = new File(rootDir, "checkstyle/checkstyle.xml")

Review Comment:
   we can perhaps change the file relative to configDirectory now instead of 
working relative to root directory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org