[GitHub] [kafka] kirktrue commented on a diff in pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager

[via GitHub]

kirktrue commented on code in PR #14359:
URL: https://github.com/apache/kafka/pull/14359#discussion_r1323611170


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##########
@@ -405,7 +274,7 @@ private List<TopicPartition> fetchablePartitions() {
      * @param partition {@link TopicPartition} for which we want to fetch data
      * @param leaderReplica {@link Node} for the leader of the given partition
      * @param currentTimeMs Current time in milliseconds; used to determine if 
we're within the optional lease window
-     * @return Replica {@link Node node} from which to request the data
+     * @return Replic {@link Node node} from which to request the data

Review Comment:
   Not sure how this keeps coming back 😦 



##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##########
@@ -405,7 +274,7 @@ private List<TopicPartition> fetchablePartitions() {
      * @param partition {@link TopicPartition} for which we want to fetch data
      * @param leaderReplica {@link Node} for the leader of the given partition
      * @param currentTimeMs Current time in milliseconds; used to determine if 
we're within the optional lease window
-     * @return Replica {@link Node node} from which to request the data
+     * @return Replic {@link Node node} from which to request the data

Review Comment:
   Not sure how this keeps coming back 😦 



##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##########
@@ -405,7 +274,7 @@ private List<TopicPartition> fetchablePartitions() {
      * @param partition {@link TopicPartition} for which we want to fetch data
      * @param leaderReplica {@link Node} for the leader of the given partition
      * @param currentTimeMs Current time in milliseconds; used to determine if 
we're within the optional lease window
-     * @return Replica {@link Node node} from which to request the data
+     * @return Replic {@link Node node} from which to request the data

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org