philipnee commented on code in PR #14386:
URL: https://github.com/apache/kafka/pull/14386#discussion_r1325175686
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -381,41 +377,41 @@ public String toString() {
}
/**
- * <p>This is used to stage the unsent {@link OffsetCommitRequestState}
and {@link OffsetFetchRequestState}.
+ * <p>This is used to stage the unsent {@link OffsetCommitRequest} and
{@link OffsetFetchRequestState}.
* <li>unsentOffsetCommits holds the offset commit requests that have not
been sent out</>
* <li>unsentOffsetFetches holds the offset fetch requests that have not
been sent out</li>
- * <li>inflightOffsetFetches holds the offset fetch requests that have
been sent out but incompleted</>.
- *
+ * <li>inflightOffsetFetches holds the offset fetch requests that have
been sent out but not completed</>.
+ * <p>
* {@code addOffsetFetchRequest} dedupes the requests to avoid sending the
same requests.
*/
class PendingRequests {
// Queue is used to ensure the sequence of commit
- Queue<OffsetCommitRequestState> unsentOffsetCommits = new
LinkedList<>();
+ Queue<OffsetCommitRequest> unsentOffsetCommits = new LinkedList<>();
List<OffsetFetchRequestState> unsentOffsetFetches = new ArrayList<>();
List<OffsetFetchRequestState> inflightOffsetFetches = new
ArrayList<>();
- public boolean hasUnsentRequests() {
+ boolean hasUnsentRequests() {
Review Comment:
Sorry - I left out commit. Fixing those obvious mistakes right away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
