[GitHub] [kafka] lianetm commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

[via GitHub]

lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1325999433


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##########
@@ -168,28 +171,41 @@ public DefaultBackgroundThread(final Time time,
                             logContext);
             CoordinatorRequestManager coordinatorRequestManager = null;
             CommitRequestManager commitRequestManager = null;
+            HeartbeatRequestManager heartbeatRequestManager = null;
+            MembershipManager membershipManaber = null;
 
+            // TODO: consolidate groupState and memberState
             if (groupState.groupId != null) {
                 coordinatorRequestManager = new CoordinatorRequestManager(
-                        this.time,
-                        logContext,
-                        retryBackoffMs,
-                        retryBackoffMaxMs,
-                        this.errorEventHandler,
-                        groupState.groupId);
+                    this.time,
+                    logContext,
+                    retryBackoffMs,
+                    retryBackoffMaxMs,
+                    this.errorEventHandler,
+                    groupState.groupId);

Review Comment:
   Totally, but is there a reason why we couldn't just use the 
`membershipManager` here already? I though that was the point of unblocking the 
state PR that includes all that's needed here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org