lucasbru commented on code in PR #14226:
URL: https://github.com/apache/kafka/pull/14226#discussion_r1326419704
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -590,6 +590,30 @@ public void prepareRecycle() {
log.info("Closed and recycled state");
}
+ @Override
+ public void preparePoll() {
Review Comment:
As for testing: I think it only makes sense to test this in conjunction with
pausing, unless we want to leak `PartitionGroup`. At first, I tried to refactor
the code so that `PartitionGroup` is injected, but after reconsideration, I
think we should only test the externally visible behavior here and leave
`PartitionGroup` encapsulated. So then, I think the
`shouldPauseAndResumeBasedOnBufferedRecords` is actually a good test for this
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
