[ 
https://issues.apache.org/jira/browse/KAFKA-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766578#comment-17766578
 ] 

Greg Harris commented on KAFKA-15473:
-------------------------------------

it appears that the bug which prompted the fix in KAFKA-15244 (wrong PluginType 
being inferred) also could cause duplicates. For example:
{noformat}
  {
    "class": "org.apache.kafka.connect.storage.StringConverter",
    "type": "converter"
  },
  {
    "class": "org.apache.kafka.connect.storage.StringConverter",
    "type": "converter"
  },{noformat}
Here, the second entry should have been "header_converter". So while there are 
more duplicates in 3.6.0-rc0 than there were in <3.6.0-rc0, the presence of 
duplicates is not new. We wouldn't be breaking any third-party clients, because 
they would already have to handle these duplicates.

> Connect connector-plugins endpoint shows duplicate plugins
> ----------------------------------------------------------
>
>                 Key: KAFKA-15473
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15473
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 3.6.0
>            Reporter: Greg Harris
>            Assignee: Greg Harris
>            Priority: Blocker
>             Fix For: 3.6.0
>
>
> In <3.6.0-rc0, only one copy of each plugin would be shown. For example:
> {noformat}
>   {
>     "class": "org.apache.kafka.connect.storage.StringConverter",
>     "type": "converter"
>   },{noformat}
> In 3.6.0-rc0, there are multiple listings for the same plugin. For example:
>  
> {noformat}
>   {
>     "class": "org.apache.kafka.connect.storage.StringConverter",
>     "type": "converter"
>   },
>   {
>     "class": "org.apache.kafka.connect.storage.StringConverter",
>     "type": "converter"
>   },
>   {
>     "class": "org.apache.kafka.connect.storage.StringConverter",
>     "type": "converter"
>   },
>   {
>     "class": "org.apache.kafka.connect.storage.StringConverter",
>     "type": "converter"
>   },
>   {
>     "class": "org.apache.kafka.connect.storage.StringConverter",
>     "type": "converter"
>   },
>   {
>     "class": "org.apache.kafka.connect.storage.StringConverter",
>     "type": "converter",
>     "version": "3.6.0"
>   },{noformat}
> These duplicates appear to happen when a plugin with the same class name 
> appears in multiple locations/classloaders.
> When interpreting a connector configuration, only one of these plugins will 
> be chosen, so only one is relevant to show to users. The REST API should only 
> display the plugins which are eligible to be loaded, and hide the duplicates.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to