[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

[via GitHub]

philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1329477649


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -136,6 +136,12 @@ public void updateState(ConsumerGroupHeartbeatResponseData 
response) {
         }
     }
 
+    @Override
+    public boolean notInGroup() {

Review Comment:
   I wonder if we could just call this "shouldHeartBeat" as the server side 
protocol is tight to the heartbeat



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org