[GitHub] [kafka] clolov commented on a diff in pull request #14404: KAFKA-14133: Move MeteredSessionStoreTest, MeteredWindowStoreTest and ReadOnlyKeyValueStoreFacadeTest to Mockito

[via GitHub]

clolov commented on code in PR #14404:
URL: https://github.com/apache/kafka/pull/14404#discussion_r1330264781


##########
streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredSessionStoreTest.java:
##########
@@ -133,45 +127,34 @@ public void before() {
     }
 
     private void init() {
-        replay(innerStore, context);
         store.init((StateStoreContext) context, store);
     }
 
     @SuppressWarnings("deprecation")
     @Test
     public void shouldDelegateDeprecatedInit() {
-        final SessionStore<Bytes, byte[]> inner = mock(SessionStore.class);
         final MeteredSessionStore<String, String> outer = new 
MeteredSessionStore<>(
-            inner,
+            innerStore,
             STORE_TYPE,
             Serdes.String(),
             Serdes.String(),
             new MockTime()
         );
-        expect(inner.name()).andStubReturn("store");

Review Comment:
   This is unneeded here and elsewhere due to being initialised in the setup 
method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org