jolshan commented on code in PR #14402:
URL: https://github.com/apache/kafka/pull/14402#discussion_r1330522384
##########
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##########
@@ -63,7 +73,42 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:
NetworkClient, time
val verificationFailureRate =
metricsGroup.newMeter(VerificationFailureRateMetricName, "failures",
TimeUnit.SECONDS)
val verificationTimeMs =
metricsGroup.newHistogram(VerificationTimeMsMetricName)
- def addTxnData(node: Node, transactionData: AddPartitionsToTxnTransaction,
callback: AddPartitionsToTxnManager.AppendCallback): Unit = {
+ def addTxnData(
+ transactionalId: String,
+ producerId: Long,
+ producerEpoch: Short,
+ verifyOnly: Boolean,
Review Comment:
We will add this functionality later, but AddPartitionsToTxnManager
currently only supports verifyOnly. In part 2, we will send
AddPartitionsToTxnRequests that actually add the partition.
I suppose this is ok since replicaManager hard codes true for now.
##########
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##########
@@ -63,7 +73,42 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:
NetworkClient, time
val verificationFailureRate =
metricsGroup.newMeter(VerificationFailureRateMetricName, "failures",
TimeUnit.SECONDS)
val verificationTimeMs =
metricsGroup.newHistogram(VerificationTimeMsMetricName)
- def addTxnData(node: Node, transactionData: AddPartitionsToTxnTransaction,
callback: AddPartitionsToTxnManager.AppendCallback): Unit = {
+ def addTxnData(
+ transactionalId: String,
+ producerId: Long,
+ producerEpoch: Short,
+ verifyOnly: Boolean,
Review Comment:
We will add this functionality later, but AddPartitionsToTxnManager
currently only supports verifyOnly=true. In part 2, we will send
AddPartitionsToTxnRequests that actually add the partition.
I suppose this is ok since replicaManager hard codes true for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
