dajac commented on code in PR #14418:
URL: https://github.com/apache/kafka/pull/14418#discussion_r1334469294
##########
server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java:
##########
@@ -14,43 +14,62 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+package org.apache.kafka.server.common;
-package org.apache.kafka.controller;
-
-import java.util.Objects;
import org.apache.kafka.common.Uuid;
-final class TopicIdPartition {
+/**
+ * Represents a partition using its unique topic Id and partition number.
+ */
+public final class TopicIdPartition {
private final Uuid topicId;
- private final int partitionId;
+ private final Integer partitionId;
Review Comment:
We should keep an int here. It is possible to implement equals and hashCode
with it (as it was before).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
