dajac commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1334471084
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ########## @@ -523,9 +526,63 @@ public CompletableFuture<DeleteGroupsResponseData.DeletableGroupResultCollection return FutureUtils.failedFuture(Errors.COORDINATOR_NOT_AVAILABLE.exception()); } - return FutureUtils.failedFuture(Errors.UNSUPPORTED_VERSION.exception( - "This API is not implemented yet." - )); + final Map<TopicPartition, List<String>> groupsByTopicPartition = new HashMap<>(); + groupIds.forEach(groupId -> { + final TopicPartition topicPartition = topicPartitionFor(groupId); + groupsByTopicPartition + .computeIfAbsent(topicPartition, __ -> new ArrayList<>()) + .add(groupId); + }); + + final List<CompletableFuture<DeleteGroupsResponseData.DeletableGroupResultCollection>> futures = + new ArrayList<>(groupIds.size()); + groupsByTopicPartition.forEach((topicPartition, groupList) -> { + CompletableFuture<DeleteGroupsResponseData.DeletableGroupResultCollection> future = + runtime.scheduleWriteOperation( + "delete-group", + topicPartition, + coordinator -> coordinator.deleteGroups(context, groupList) + ).exceptionally(exception -> { + if (exception instanceof UnknownTopicOrPartitionException || + exception instanceof NotEnoughReplicasException) { + return DeleteGroupsRequest.getErrorResultCollection( + groupIds, + Errors.COORDINATOR_NOT_AVAILABLE + ); + } + + if (exception instanceof NotLeaderOrFollowerException || + exception instanceof KafkaStorageException) { + return DeleteGroupsRequest.getErrorResultCollection( + groupIds, + Errors.NOT_COORDINATOR + ); + } + + if (exception instanceof RecordTooLargeException || + exception instanceof RecordBatchTooLargeException || + exception instanceof InvalidFetchSizeException) { + return DeleteGroupsRequest.getErrorResultCollection( + groupIds, + Errors.UNKNOWN_SERVER_ERROR + ); + } + + return DeleteGroupsRequest.getErrorResultCollection( + groupIds, + Errors.forException(exception) + ); + }); + + futures.add(future); + }); + + final CompletableFuture<Void> allFutures = CompletableFuture.allOf(futures.toArray(new CompletableFuture[0])); Review Comment: @jeffkbkim I made the same comment earlier and @dongnuo123 updated the code to handle exceptions for each write operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org