cmccabe commented on code in PR #14399:
URL: https://github.com/apache/kafka/pull/14399#discussion_r1334856841
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -719,38 +726,66 @@ public Node provide() {
abstract class Call {
private final boolean internal;
+ private final boolean supportsUseControllers;
private final String callName;
private final long deadlineMs;
private final NodeProvider nodeProvider;
protected int tries;
private Node curNode = null;
private long nextAllowedTryMs;
- Call(boolean internal,
- String callName,
- long nextAllowedTryMs,
- int tries,
- long deadlineMs,
- NodeProvider nodeProvider
+ Call(
Review Comment:
I agree that this is a bit confusing. I'll cut it down to just 3
constructors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
