tombentley commented on code in PR #13862:
URL: https://github.com/apache/kafka/pull/13862#discussion_r1336627061
##########
docs/quickstart.html:
##########
@@ -154,9 +154,9 @@ <h4 class="anchor-heading">
By default, each line you enter will result in a separate event
being written to the topic.
</p>
- <pre class="line-numbers"><code class="language-bash">$
bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server
localhost:9092
-This is my first event
-This is my second event</code></pre>
+ <pre class="language-bash"><code class="language-bash">$
bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server
localhost:9092
+> This is my first event
+> This is my second event</code></pre>
Review Comment:
The console producer doesn't actually include a space after the `>`.
##########
docs/quickstart.html:
##########
@@ -32,7 +32,7 @@ <h4 class="anchor-heading">
the latest Kafka release and extract it:
</p>
- <pre class="line-numbers"><code class="language-bash">$ tar -xzf
kafka_{{scalaVersion}}-{{fullDotVersion}}.tgz
+ <pre class="language-bash"><code class="language-bash">$ tar -xzf
kafka_{{scalaVersion}}-{{fullDotVersion}}.tgz
Review Comment:
It works fine for me with `<pre><code class="language-bash">`, using both FF
and a chrome-based browser.
##########
docs/streams/quickstart.html:
##########
@@ -152,8 +150,8 @@ <h4><a id="quickstart_streams_prepare"
href="#quickstart_streams_prepare">Step 3
Next, we create the input topic named <b>streams-plaintext-input</b> and the
output topic named <b>streams-wordcount-output</b>:
-<pre class="line-numbers"><code class="language-bash">> bin/kafka-topics.sh
--create \
- --bootstrap-server localhost:9092 \
+<pre class="language-bash"><code class="language-bash">$ bin/kafka-topics.sh
--create \
+--bootstrap-server localhost:9092 \
Review Comment:
We should keep the indentation of this line (as we do for the following
continuation lines).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
