dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1345534442
##########
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##########
@@ -123,50 +124,79 @@ class CoordinatorPartitionWriter[T](
val maxBatchSize = logConfig.maxMessageSize
val currentTimeMs = time.milliseconds()
- val recordsBuilder = MemoryRecords.builder(
- ByteBuffer.allocate(math.min(16384, maxBatchSize)),
- magic,
- compressionType,
- TimestampType.CREATE_TIME,
- 0L,
- maxBatchSize
- )
+ var recordsBuilder: MemoryRecordsBuilder = null
Review Comment:
@jeffkbkim This change cannot be applied to all cases. For all the records
written by the new protocol, the atomicity matters. I think that we should
revert this for now and discuss how to address this within the framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
