showuon commented on code in PR #14484:
URL: https://github.com/apache/kafka/pull/14484#discussion_r1347305265
##########
docs/upgrade.html:
##########
@@ -144,8 +144,10 @@ <h5><a id="upgrade_350_kraft"
href="#upgrade_350_kraft">Upgrading KRaft-based cl
./bin/kafka-features.sh upgrade --metadata 3.5
</code>
</li>
- <li>Note that the cluster metadata version cannot be downgraded to a
pre-production 3.0.x, 3.1.x, or 3.2.x version once it has been upgraded.
- However, it is possible to downgrade to production versions such
as 3.3-IV0, 3.3-IV1, etc.</li>
+ <li>Note that cluster metadata downgrade is not supported, although it
might be possible to do a safe downgrade in some cases.
+ Every <a
href="https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java";>MetadataVersion</a>
+ after 3.2.x has a boolean parameter that indicates if there are
metadata changes (i.e. <code>IBP_3_3_IV3(7, "3.3", "IV3", true)</code>).
Review Comment:
`(i.e. <code>IBP_3_3_IV3(7, "3.3", "IV3", true)</code>).` -> `(ex:
<code>IBP_3_3_IV3(7, "3.3", "IV3", true)</code> means this version has metadata
changes).`
##########
docs/upgrade.html:
##########
@@ -144,8 +144,10 @@ <h5><a id="upgrade_350_kraft"
href="#upgrade_350_kraft">Upgrading KRaft-based cl
./bin/kafka-features.sh upgrade --metadata 3.5
</code>
</li>
- <li>Note that the cluster metadata version cannot be downgraded to a
pre-production 3.0.x, 3.1.x, or 3.2.x version once it has been upgraded.
- However, it is possible to downgrade to production versions such
as 3.3-IV0, 3.3-IV1, etc.</li>
+ <li>Note that cluster metadata downgrade is not supported, although it
might be possible to do a safe downgrade in some cases.
Review Comment:
I'm thinking this sentence is too strong: `Note that cluster metadata
downgrade is not supported`.
Maybe:
`Note that cluster metadata downgrade might be possible in some cases. Every
<a
href="https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java";>MetadataVersion</a>
after 3.2.x has a boolean parameter...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
