rondagostino commented on code in PR #14291: URL: https://github.com/apache/kafka/pull/14291#discussion_r1347490234
########## core/src/main/scala/kafka/log/LogManager.scala: ########## @@ -117,6 +117,8 @@ class LogManager(logDirs: Seq[File], } private val dirLocks = lockLogDirs(liveLogDirs) + private val dirIds = directoryIds(liveLogDirs) + val directoryIds: Set[Uuid] = dirIds.values.toSet Review Comment: Seems this is only used in the test, so can we do this instead? ``` // visible for testing private[log] val directoryIds: Set[Uuid] = dirIds.values.toSet ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org