jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1348377598
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorRuntimeMetrics.java: ########## @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.metrics; + +import com.yammer.metrics.core.Histogram; +import com.yammer.metrics.core.MetricsRegistry; +import org.apache.kafka.common.MetricName; +import org.apache.kafka.common.metrics.Gauge; +import org.apache.kafka.common.metrics.Metrics; +import org.apache.kafka.common.metrics.Sensor; +import org.apache.kafka.common.metrics.stats.Avg; +import org.apache.kafka.common.metrics.stats.Max; +import org.apache.kafka.common.metrics.stats.Min; +import org.apache.kafka.coordinator.group.runtime.CoordinatorRuntime.CoordinatorState; +import org.apache.kafka.server.metrics.KafkaYammerMetrics; + +import java.util.Arrays; +import java.util.Objects; +import java.util.concurrent.atomic.AtomicLong; +import java.util.function.Consumer; +import java.util.function.Supplier; + +public class GroupCoordinatorRuntimeMetrics implements CoordinatorRuntimeMetrics { + /** + * The metrics group. + */ + public static final String METRICS_GROUP = "group-coordinator-metrics"; + + /** + * Metric to count the number of partitions in Loading state. + */ + private final MetricName numPartitionsLoading; + + /** + * The Loading state partition counter. + */ + private final AtomicLong numPartitionsLoadingCounter = new AtomicLong(0); + + /** + * Metric to count the number of partitions in Active state. + */ + private final MetricName numPartitionsActive; + + /** + * The Active state partition counter. + */ + private final AtomicLong numPartitionsActiveCounter = new AtomicLong(0); + + /** + * Metric to count the number of partitions in Failed state. + */ + private final MetricName numPartitionsFailed; + + /** + * The Failed state partition counter. + */ + private final AtomicLong numPartitionsFailedCounter = new AtomicLong(0); + + /** + * Metric to count the size of the processor queue. + */ + private final MetricName eventQueueSize; + + /** + * Metric to measure the event queue time. + */ + private final com.yammer.metrics.core.MetricName eventQueueTimeMs = + KafkaYammerMetrics.getMetricName("kafka.coordinator.group", METRICS_GROUP, "EventQueueTimeMs"); + + /** + * Metric to measure the event processing time. + */ + private final com.yammer.metrics.core.MetricName eventQueueProcessingTimeMs = + KafkaYammerMetrics.getMetricName("kafka.coordinator.group", METRICS_GROUP, "EventQueueProcessingTimeMs"); + + /** + * The yammer metrics registry. + */ + private final MetricsRegistry registry; + + /** + * The Kafka metrics registry. + */ + private final Metrics metrics; + + /** + * The partition load sensor. + */ + private Sensor partitionLoadSensor; + + /** + * The thread idle sensor. + */ + private Sensor threadIdleRatioSensor; + + /** + * The event queue time updater. + */ + private final Consumer<Long> eventQueueTimeUpdater; + + /** + * The event queue processing time updater. + */ + private final Consumer<Long> eventQueueProcessingTimeUpdater; + + public GroupCoordinatorRuntimeMetrics(MetricsRegistry registry, Metrics metrics) { + this.registry = Objects.requireNonNull(registry); + this.metrics = Objects.requireNonNull(metrics); + + this.numPartitionsLoading = getMetricName("num-partitions-loading"); + this.numPartitionsActive = getMetricName("num-partitions-active"); + this.numPartitionsFailed = getMetricName("num-partitions-failed"); + this.eventQueueSize = getMetricName("event-queue-size"); + + initializeMetrics(); + + eventQueueTimeUpdater = newHistogram(eventQueueTimeMs); + eventQueueProcessingTimeUpdater = newHistogram(eventQueueProcessingTimeMs); + } + + /** + * Register the metrics. + */ + public void initializeMetrics() { + metrics.addMetric(numPartitionsLoading, (Gauge<Long>) (config, now) -> numPartitionsLoadingCounter.get()); + metrics.addMetric(numPartitionsActive, (Gauge<Long>) (config, now) -> numPartitionsActiveCounter.get()); + metrics.addMetric(numPartitionsFailed, (Gauge<Long>) (config, now) -> numPartitionsFailedCounter.get()); + + this.partitionLoadSensor = metrics.sensor("GroupPartitionLoadTime"); + this.partitionLoadSensor.add( + metrics.metricName( + "partition-load-time-max", + METRICS_GROUP, + "The max time it took to load the partitions in the last 30 sec." + ), new Max()); + this.partitionLoadSensor.add( + metrics.metricName( + "partition-load-time-avg", + METRICS_GROUP, + "The average time it took to load the partitions in the last 30 sec." + ), new Avg()); + + this.threadIdleRatioSensor = metrics.sensor("ThreadIdleRatio"); + this.threadIdleRatioSensor.add( + metrics.metricName( + "thread-idle-ratio-min", + METRICS_GROUP, + "The minimum thread idle ratio over the last 30 seconds." + ), new Min()); + this.threadIdleRatioSensor.add( + metrics.metricName( + "thread-idle-ratio-avg", + METRICS_GROUP, + "The average thread idle ratio over the last 30 seconds." + ), new Avg()); + } + + /** + * Retrieve the yammer metric name. + * @param name The name of the metric. + * + * @return The metric name. + */ + private MetricName getMetricName(String name) { Review Comment: That's correct. I updated both GroupCoordinatorRuntimeMetrics and GroupCoordinatorRuntimeMetricsTest to always use `com.yammer.metrics.core.MetricName` for yammer metrics and `MetricName` for kafka metrics. Also, i fixed the comments and renamed this to kafkaMetricName -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
