VictorvandenHoven commented on PR #14426: URL: https://github.com/apache/kafka/pull/14426#issuecomment-1750158783
> Thanks for the PR. I did not forget about it (sorry for the wait; very busy times...). > > > Moved the "emit non-joined items"-logic after the "joined items"-logic instead of before, because only then you know whether to emit or not. > > Can you elaborate? Not sure if I can follow? Sure. If not-joined record is emitted at window-close, but there is also a joined-record available at that time, then both not-joined and joined would be emitted wouldn't they? In the joined-item-logic the not-joined record in the outerJoinStore is nullified (correctly) but it has already been emitted before. Or am I mistaken? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
