dajac commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1349654092
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ########## @@ -106,15 +107,29 @@ void validateOffsetFetch( /** * Returns true if the group is actively subscribed to the topic. * - * @param topic The topic name. + * @param topic The topic name. + * @param isSubscribedIfEmptySubscriptions Whether to consider an empty topic subscriptions subscribed or not. + * * @return Whether the group is subscribed to the topic. */ - boolean isSubscribedToTopic(String topic); + boolean isSubscribedToTopic(String topic, boolean isSubscribedIfEmptySubscriptions); Review Comment: I made a comment about this boolean [here](https://github.com/apache/kafka/pull/14467#discussion_r1348539504). Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org