clolov commented on code in PR #14412:
URL: https://github.com/apache/kafka/pull/14412#discussion_r1350155561
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilderTest.java:
##########
@@ -223,38 +208,9 @@ public void shouldThrowNullPointerIfInnerIsNull() {
assertThrows(NullPointerException.class, () -> new
TimestampedWindowStoreBuilder<>(null, Serdes.String(), Serdes.String(), new
MockTime()));
}
- @Test
- public void shouldThrowNullPointerIfKeySerdeIsNull() {
- assertThrows(NullPointerException.class, () -> new
TimestampedWindowStoreBuilder<>(supplier, null, Serdes.String(), new
MockTime()));
- }
-
- @Test
- public void shouldThrowNullPointerIfValueSerdeIsNull() {
- assertThrows(NullPointerException.class, () -> new
TimestampedWindowStoreBuilder<>(supplier, Serdes.String(), null, new
MockTime()));
- }
-
@Test
public void shouldThrowNullPointerIfTimeIsNull() {
assertThrows(NullPointerException.class, () -> new
TimestampedWindowStoreBuilder<>(supplier, Serdes.String(), Serdes.String(),
null));
}
- @Test
- public void shouldThrowNullPointerIfMetricsScopeIsNull() {
Review Comment:
This is a fair point, the problem here is that the setUp method mocked the
supplier.metricScope to return a non-null value. I have remedied this since,
thank you for the thorough review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
