imcdo commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355617795
########## tests/kafkatest/tests/core/consume_bench_test.py: ########## @@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=10000): self.logger.debug("Produce workload finished") @cluster(num_nodes=10) - @matrix(topics=[["consume_bench_topic[0-5]"]], metadata_quorum=quorum.all_non_upgrade) # topic subscription - @matrix(topics=[["consume_bench_topic[0-5]:[0-4]"]], metadata_quorum=quorum.all_non_upgrade) # manual topic assignment - def test_consume_bench(self, topics, metadata_quorum=quorum.zk): + @matrix( + topics=[ + ["consume_bench_topic[0-5]"], + ["consume_bench_topic[0-5]:[0-4]"] + ], + metadata_quorum=quorum.all_non_upgrade, + use_new_coordinator=[True, False] + ) # topic subscription Review Comment: I think the biggest object to that proposition i have is it isn't sustainable to any other kraft only configs that might have to be added in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org