[
https://issues.apache.org/jira/browse/KAFKA-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505975#comment-16505975
]
ASF GitHub Bot commented on KAFKA-6946:
---------------------------------------
jonlee2 opened a new pull request #5164: KAFKA-6946: Keep the session id for
incremental fetch when fetch resp…
URL: https://github.com/apache/kafka/pull/5164
…onses are throttled
Currently, a throttled fetch response is returned with INVALID_SESSION_ID,
which causes dropping the current fetch session if incremental fetch is in
progress. This patch fixes this by returning the correct session id.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Keep the session id for incremental fetch when fetch responses are throttled
> -----------------------------------------------------------------------------
>
> Key: KAFKA-6946
> URL: https://issues.apache.org/jira/browse/KAFKA-6946
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.0.0
> Reporter: Jon Lee
> Priority: Major
>
> The current patch for KAFKA-6028 (KIP-219) sends a FetchResponse with
> INVALID_SESSION_ID if the response needs to be throttled due to quota
> violation. If it is for incremental fetch, this will make the client reset
> its session and send a full fetch request next time. This is not a
> correctness issue, but it may affect performance when fetches are throttled.
> In case of incremental fetch, a throttled response should use the same
> session id as before so that the next unthrottled response can be in the same
> session.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
