philipnee commented on code in PR #14532:
URL: https://github.com/apache/kafka/pull/14532#discussion_r1358640330
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -254,28 +250,38 @@ public String toString() {
}
}
- public static class FutureCompletionHandler implements
RequestCompletionHandler {
+ public static class FutureCompletionHandler extends
CompletableFuture<ClientResponse> implements RequestCompletionHandler {
- private final CompletableFuture<ClientResponse> future;
+ /**
+ * The time when the response is completed. This is used when the
response is completed exceptionally because
+ * ClientResponse already contains received time which is injected by
the network client.
+ */
Review Comment:
Thanks, I think I was trying to say the main use of responseCompletionTimeMs
is mainly used when the future gets completed exceptionally. For the
successful requests, we could use either the ClientResponse or this time. I'll
remove this comment to avoid the ambiguity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
