guozhangwang commented on code in PR #14508:
URL: https://github.com/apache/kafka/pull/14508#discussion_r1359038910
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -223,10 +223,7 @@ boolean handleCorruption(final Set<TaskId> corruptedTasks)
{
final Collection<Task> tasksToCommit = allTasks()
.values()
.stream()
- // TODO: once we remove state restoration from the stream
thread, we can also remove
- // the RESTORING state here, since there will not be any
restoring tasks managed
- // by the stream thread anymore.
- .filter(t -> t.state() == Task.State.RUNNING || t.state() ==
Task.State.RESTORING)
+ .filter(t -> t.state() == Task.State.RUNNING)
Review Comment:
Hey @cadonna sorry I came late on this PR.
One thing I'd like to raise is that in the past, we've seen active task
restoring never complete under rolling restart / rebalance storm scenarios
since we kept losing the progress we made thus far when reviving. I'm not 100%
sure if this part of the code is related to that scenario but just try to
double check. If you have thought about it and concluded this would not be
related, I'm relieved :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
