showuon commented on code in PR #14483:
URL: https://github.com/apache/kafka/pull/14483#discussion_r1359202415
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##########
@@ -193,7 +192,16 @@ public File cacheDir() {
public void remove(Uuid key) {
lock.readLock().lock();
try {
- internalCache.invalidate(key);
+ internalCache.asMap().computeIfPresent(key, (k, v) -> {
+ try {
+ v.markForCleanup();
+ expiredIndexes.put(v);
Review Comment:
Do something like we did in the other place:
```
if (!expiredIndexes.offer(entry)) {
log.error("Error while inserting entry {} for
key {} into the cleaner queue because queue is full.", entry, key);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
