CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1361388641
########## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ########## @@ -362,6 +405,35 @@ private void setAssignmentChanges(PartitionChangeRecord record) { } } + private void populateTargetElr() { + // If the ISR is larger or equal to the min ISR, clear the ELR and lastKnownELR. + if (targetIsr.size() >= minISR) { + targetElr = Collections.emptyList(); + targetLastKnownElr = Collections.emptyList(); + return; + } + Review Comment: Sorry, where to add a line? Before return? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org