philipnee commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1361474872
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -135,6 +146,7 @@ public void updateState(ConsumerGroupHeartbeatResponseData
response) {
public void transitionToFenced() {
resetEpoch();
transitionTo(MemberState.FENCED);
+ assignmentReconciler.startLost();
Review Comment:
I think this is actually fine, because the heartbeat won't be sent in the
FENCED state. I see that completeLost() is invoked after the callback completes
- there I think we can ask the member to rejoin by invoking tryJoin() (which is
in my PR).
Technically - The member should try to rejoin after being fenced, but
there's no guarantee to it. In this case - we rely on callback completion
signal to ask the member to rejoin. This is what i meant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
