dajac commented on code in PR #14357:
URL: https://github.com/apache/kafka/pull/14357#discussion_r1362057720
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -1294,7 +1294,7 @@ boolean generationUnchanged() {
}
}
- protected final Meter createMeter(Metrics metrics, String groupName,
String baseName, String descriptiveName) {
+ static Meter createMeter(Metrics metrics, String groupName, String
baseName, String descriptiveName) {
Review Comment:
It is a bit weird to just expose it like this. `createMeter` does not mean
much outside of the usages within this class and sub-class. We could perhaps
find a better place for this one and also find a better name. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
