apoorvmittal10 commented on PR #14566:
URL: https://github.com/apache/kafka/pull/14566#issuecomment-1767932760
> Hi @apoorvmittal10 - Thanks for the PR. I left two comments, similar to
@mjsax 's:
>
> 1. It seems like internal package is a good place for the state machine
> 2. IllegalStateException should be good enough
1. I have created another packages in commons called telemetry where I am
planning to push most of the code specifically for KIP-714. I think the
commons.internal is not holding much of internal classes but mostly in the
respective packages under common.
2. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
