mimaison commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1363651995
##########
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##########
@@ -16,7 +16,7 @@
*/
Review Comment:
Do we have a Jira to remind us to update the few test that are disabled on
KRaft once JBOD is available?
##########
core/src/test/scala/other/kafka/ReplicationQuotasTestRig.scala:
##########
@@ -1,340 +0,0 @@
-/**
Review Comment:
What happens to this file? Do we plan to migrate it too or are we deleting
it?
##########
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##########
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
@SuppressWarnings("unchecked")
- private static <T> scala.collection.immutable.Set<T> set(final T... set) {
- return mutableSet(set).toSet();
- }
-
- @SuppressWarnings({"deprecation", "unchecked"})
- private static <T> scala.collection.mutable.Set<T> mutableSet(final
T...set) {
- return JavaConverters.asScalaSet(new HashSet<>(Arrays.asList(set)));
+ private static <T> Set<T> set(final T... set) {
+ return new HashSet<>(Arrays.asList(set));
}
- @SuppressWarnings({"deprecation", "unchecked"})
- private static <T> Seq<T> seq(T... seq) {
- return
JavaConverters.asScalaIteratorConverter(Arrays.asList(seq).iterator()).asScala().toSeq();
- }
-
- @SuppressWarnings("deprecation")
- private static <K, V> scala.collection.Map<K, V> asScala(Map<K, V> jmap) {
- return JavaConverters.mapAsScalaMap(jmap);
+ @SuppressWarnings("unchecked")
Review Comment:
Do we really need this? If you're really after saving characters, we could
import static Arrays.asList
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
