[ https://issues.apache.org/jira/browse/KAFKA-15637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kirk True updated KAFKA-15637: ------------------------------ Description: Thanks for the reply. I still don't quite understand the test. Why do we duplicate the following code both inside and outside of {{{}setWakeupHook{}}}? {code:java} networkClientDelegate.disconnectAsync(readReplica); networkClientDelegate.poll(time.timer(0)); {code} MockClient is only woken up through {{{}networkClientDelegate.disconnectAsync{}}}. was: Thanks for the reply. I still don't quite understand the test. Why do we duplicate the following code both inside and outside of setWakeupHook? {code:java} networkClientDelegate.disconnectAsync(readReplica); networkClientDelegate.poll(time.timer(0)); {code} MockClient is only woken up through {{{}networkClientDelegate.disconnectAsync{}}}. > CLONE - Investigate FetcherTest's/FetchRequestManager's > testFetchCompletedBeforeHandlerAdded > -------------------------------------------------------------------------------------------- > > Key: KAFKA-15637 > URL: https://issues.apache.org/jira/browse/KAFKA-15637 > Project: Kafka > Issue Type: Sub-task > Components: clients, consumer > Reporter: Kirk True > Assignee: Kirk True > Priority: Minor > Labels: consumer-threading-refactor > > Thanks for the reply. I still don't quite understand the test. Why do we > duplicate the following code both inside and outside of {{{}setWakeupHook{}}}? > > {code:java} > networkClientDelegate.disconnectAsync(readReplica); > networkClientDelegate.poll(time.timer(0)); > {code} > > MockClient is only woken up through > {{{}networkClientDelegate.disconnectAsync{}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010)