philipnee commented on code in PR #14532:
URL: https://github.com/apache/kafka/pull/14532#discussion_r1364845881
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -188,9 +188,7 @@ private NetworkClientDelegate.UnsentRequest
makeHeartbeatRequest() {
if (response != null) {
onResponse((ConsumerGroupHeartbeatResponse)
response.responseBody(), response.receivedTimeMs());
Review Comment:
Thanks
`request.handler().completionTimeMs() instead of response.receivedTimeMs()`
- This is addressed
`UnsentRequest using request.handler() would not be possible` - Let me
quickly follow up with a MINOR PR to address this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
