jsancio commented on code in PR #14489:
URL: https://github.com/apache/kafka/pull/14489#discussion_r1365713469
##########
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##########
@@ -218,7 +218,11 @@ public void testBasicLocalChanges() {
);
assertEquals(
new HashSet<>(Arrays.asList(new TopicPartition("baz", 0))),
- changes.leaders().keySet()
+ changes.electedLeaders().keySet()
Review Comment:
Looks like there are 4 extra spaces here.
##########
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##########
@@ -218,7 +218,11 @@ public void testBasicLocalChanges() {
);
assertEquals(
new HashSet<>(Arrays.asList(new TopicPartition("baz", 0))),
- changes.leaders().keySet()
+ changes.electedLeaders().keySet()
+ );
+ assertEquals(
+ new HashSet<>(Arrays.asList(new TopicPartition("baz", 0))),
+ changes.updatedLeaders().keySet()
Review Comment:
Looks like there are 4 extra spaces here.
##########
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##########
@@ -278,6 +283,41 @@ public void testDeleteAfterChanges() {
testToImage(finalImage, Optional.of(imageRecords));
}
+ @Test
+ public void testUpdatedLeaders() {
+ int localId = 3;
+ Uuid zooId = Uuid.fromString("0hHJ3X5ZQ-CFfQ5xgpj90w");
+
+ List<TopicImage> topics = new ArrayList<>();
+ topics.add(
+ newTopicImage(
+ "zoo",
+ zooId,
+ newPartition(new int[] {localId, 1, 2})
+ )
Review Comment:
In Apache Kafka, we indent by 4 spaces in the Java code. Some line here have
extra 4 spaces, other lines have extra 8 spaces.
This comment applies to a few lines int his file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
