jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1365849662
##########
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##########
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
@SuppressWarnings("unchecked")
- private static <T> scala.collection.immutable.Set<T> set(final T... set) {
- return mutableSet(set).toSet();
- }
-
- @SuppressWarnings({"deprecation", "unchecked"})
- private static <T> scala.collection.mutable.Set<T> mutableSet(final
T...set) {
- return JavaConverters.asScalaSet(new HashSet<>(Arrays.asList(set)));
+ private static <T> Set<T> set(final T... set) {
+ return new HashSet<>(Arrays.asList(set));
}
- @SuppressWarnings({"deprecation", "unchecked"})
- private static <T> Seq<T> seq(T... seq) {
- return
JavaConverters.asScalaIteratorConverter(Arrays.asList(seq).iterator()).asScala().toSeq();
- }
-
- @SuppressWarnings("deprecation")
- private static <K, V> scala.collection.Map<K, V> asScala(Map<K, V> jmap) {
- return JavaConverters.mapAsScalaMap(jmap);
+ @SuppressWarnings("unchecked")
Review Comment:
Can we get rid of this method now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
