bachmanity1 commented on code in PR #14410:
URL: https://github.com/apache/kafka/pull/14410#discussion_r1368375859
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsProducerTest.java:
##########
@@ -1173,17 +1126,13 @@ public void
shouldResetTransactionInitializedOnResetProducer() {
);
streamsProducer.initTransaction();
- reset(mockedProducer);
- mockedProducer.close();
- mockedProducer.initTransactions();
Review Comment:
I think the goal of this test is to make sure that `resetProducer` method
resets `transactionInitialized` field so that subsequent call of the
`initTransactions` method can start new transaction. Easymock expects
`mockedProducer.initTransactions()` only once because of the `reset()` on line
1176. As far as I know there is no equivalent of `reset()` in Mockito, so I
think the best we can do is to check that `mockedProducer.initTransactions()`
is called twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
