OmniaGM commented on code in PR #14516:
URL: https://github.com/apache/kafka/pull/14516#discussion_r1368826071
##########
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##########
@@ -128,7 +128,7 @@ class ZkMigrationIntegrationTest {
val underlying =
clusterInstance.asInstanceOf[ZkClusterInstance].getUnderlying()
val zkClient = underlying.zkClient
- val migrationClient = ZkMigrationClient(zkClient, PasswordEncoder.noop())
+ val migrationClient = ZkMigrationClient(zkClient, PasswordEncoder.noop(),
MetadataVersion.latest())
Review Comment:
nit: Same as `replicaBrokerIds`, `MetadataVersion.latest` has no side-effect
so it should be called without empty parentheses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
