kirktrue commented on code in PR #14565: URL: https://github.com/apache/kafka/pull/14565#discussion_r1368989675
########## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ########## @@ -961,7 +960,7 @@ public void subscribe(Collection<String> topics, ConsumerRebalanceListener liste */ @Override public void subscribe(Collection<String> topics) { - subscribe(topics, new NoOpConsumerRebalanceListener()); + subscribe(topics, null); Review Comment: You're right. I reworked it a bit so that we still keep the same semantics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org